Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort-comp ClassExpression #1082

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Fix sort-comp ClassExpression #1082

merged 2 commits into from
Jun 27, 2017

Conversation

webOS101
Copy link
Contributor

Fixes #1076. Also adds test.

ljharb
ljharb reviewed Feb 21, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind also including tests for return class {} and class Foo {}, just in case?

@webOS101
Copy link
Contributor Author

To be clear, you're asking for non-react component class tests? I will add those.

@ljharb ljharb added the bug label Feb 21, 2017
@lencioni lencioni merged commit 07b6373 into jsx-eslint:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@lencioni lencioni lencioni approved these changes

@yannickcr yannickcr Awaiting requested review from yannickcr

@EvHaus EvHaus Awaiting requested review from EvHaus

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webOS101 @ljharb @lencioni